Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add histogram of report shares by VDAF parameters #3166

Merged
merged 1 commit into from
May 28, 2024
Merged

Add histogram of report shares by VDAF parameters #3166

merged 1 commit into from
May 28, 2024

Conversation

divergentdave
Copy link
Collaborator

This is the first part of #3165. It adds a new histogram metric to supersede janus_report_aggregation_success_counter, but with additional labels for VDAF type and size buckets. I set the "dimension" to 1 for Prio3Count, "bits" for Prio3Sum, "length" for Prio3Histogram, "length * bits" for Prio3SumVec, etc. Here's some sample output.

# HELP janus_aggregated_report_share_vdaf_dimension Successfully aggregated report shares
# TYPE janus_aggregated_report_share_vdaf_dimension histogram
janus_aggregated_report_share_vdaf_dimension_bucket{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator",le="1"} 0
janus_aggregated_report_share_vdaf_dimension_bucket{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator",le="4"} 0
janus_aggregated_report_share_vdaf_dimension_bucket{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator",le="16"} 0
janus_aggregated_report_share_vdaf_dimension_bucket{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator",le="64"} 0
janus_aggregated_report_share_vdaf_dimension_bucket{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator",le="256"} 0
janus_aggregated_report_share_vdaf_dimension_bucket{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator",le="1024"} 0
janus_aggregated_report_share_vdaf_dimension_bucket{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator",le="4096"} 0
janus_aggregated_report_share_vdaf_dimension_bucket{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator",le="16384"} 0
janus_aggregated_report_share_vdaf_dimension_bucket{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator",le="65536"} 7500
janus_aggregated_report_share_vdaf_dimension_bucket{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator",le="262144"} 8520
janus_aggregated_report_share_vdaf_dimension_bucket{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator",le="+Inf"} 8520
janus_aggregated_report_share_vdaf_dimension_sum{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator"} 289507500
janus_aggregated_report_share_vdaf_dimension_count{type="Prio3SumVecField64MultiproofHmacSha256Aes128",otel_scope_name="janus_aggregator"} 8520

@divergentdave divergentdave requested a review from a team as a code owner May 24, 2024 18:03
@divergentdave divergentdave merged commit 562db4b into main May 28, 2024
9 checks passed
@divergentdave divergentdave deleted the david/histogram-by-vdaf-dimension branch May 28, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inahga inahga inahga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@divergentdave @inahga